add message reactions

[anxodio]

Description

This PR add reaction capabilities to opsdroid, adding a new react method in Message and Connector.

By default it just log a debug message and return False, but can be implemented by connectors that have react capabilities (like Slack or Github).

Fixes #442

Status

READY

Type of change

• New feature (non-breaking change which adds functionality)
• This change requires a documentation update

(By now it will be documented in the Slack connector, because it will be the only one that implements it)

How Has This Been Tested?

I tested and checked that the new react methods returns False as expected.

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation (if applicable)
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[codecov]

Codecov Report

Merging #459 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #459   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          18     18           
  Lines        1095   1104    +9     
=====================================
+ Hits         1095   1104    +9

Impacted Files	Coverage Δ
opsdroid/connector.py	100% <100%> (ø)	⬆️
opsdroid/message.py	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45cb64...140b38a. Read the comment docs.

[jacobtomlinson]

This looks great!

You're missing a test for the case where thinking-delay is set in the config. As there is no else statement you could always just add it to the config on the connector in test_react().

[jacobtomlinson]

The code looks good and the tests are passing now. So it just needs adding to the docs and it's good to go!

[anxodio]

Sorry, but i'm not sure of where to put this in the documentation. As I writed:

(By now it will be documented in the Slack connector, because it will be the only one that implements it)

And the documentation is in the other PR: opsdroid/connector-slack#10

So, if we have to add it here, where you would add it?

[FabioRosado]

Since this is a new method of the connector class I think the right place for it would be in the connector documentation

Hope this helps 👍

[jacobtomlinson]

Awesome many thanks!