-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Slack and Websocket connectors to the core project #530
Merge Slack and Websocket connectors to the core project #530
Conversation
Codecov Report
@@ Coverage Diff @@
## master #530 +/- ##
========================================
+ Coverage 99.91% 100% +0.08%
========================================
Files 18 20 +2
Lines 1135 1312 +177
========================================
+ Hits 1134 1312 +178
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
I looked over at the code and I know you are still working on it. The idea is to move all the other connectors into opsdroid core right? Or slack will be the only one moved at the moment? (I guess people would use slack more than any of the others) |
Yeah the idea is to eventually move all the connectors and database modules into the core project. I just wanted to take it in small chunks as it is quite a lot of work. So this PR updated the loader to look for modules in the core project first and adds the first two connectors. Once it's finished and merged I'll start looking into the other modules. I was hoping for some of them like the matrix connector which was written by someone else that I could get them to help merge it in. |
I'm not sure if you are still working on this Jacob but I assume it's pretty much done, I got some time to go through it today and this looks good let me know if you want it merged now 😄 👍 |
This still needs documenting. Sorry I've been busy and this slipped my mind. |
It’s okay it happens :D I’ve been busy learning js as well haha |
If you're happy to help then yes please! |
Hey Jacob I just wanted to check with you a few things. For me to submit commits into your PR do I just need to add you as a remote on my end, create a branch and then push these changes into your own branch? The tutorial do you want me to write just how to set it up (like config options and whatnot?) The builtin connectors documentation should I just update the connector documentation and mention this fact, or would you prefer to have a new file for this? Thanks |
Yes you should be able you add my fork as a remote. I think we need to update the connector docs to say there are builtin connectors and you can use plugins. We should also have a documentation page for each built-in, like we have for parsers. |
I've changed just a bit of the documentation since you started with it anyway. I didn't create a tutorial on how to set it up because I have also tested to see if opsdroid would connect to slack and respond to --EDIT-- |
Sorry I haven't had a chance to look at this, been super busy this last week. Do you mean test failures of readthedocs failures? |
It's okay sometimes we get extremely busy with work and life 👍 |
Ah interesting! The tests seem to be passing here so perhaps you could raise it as a separate issue? Thanks again for adding the documentation, huge help! |
Description
This PR is the start of the work on #185 by adding the Slack and Websocket connectors into the core project.
The loader now checks for connector modules within the opsdroid core library before looking to load an external plugin. This makes it fully backward compatible.
Status
UNDER DEVELOPMENT
Type of change
How Has This Been Tested?
New unit tests have been added to fully test the code within the connectors, however the third party APIs have been mocked.
Checklist: