New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP 101 (Core protocol) updated #272
Conversation
Hi, any feedback on this ? |
|
||
(source: :rfc:`7231`) | ||
|
||
After the empty line, an eventual body message contains the payload (data) of the request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clarify that the body is part of the response?
@bverschueren awesome stuff, added some comments. Feel free to address them, and then squash commits down to a single commit in this PR. |
|
||
In name-based virtual hosting a web server serves multiple host names on a single IP address. | ||
While a client is connecting to a webserver, the destination address is resolved to an IP address either by DNS or local lookup table. | ||
As several virtual hosts may be hosted on the same IP, the client needs to state which website it is reaching for by setting the ``Host`` header. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about "requesting" instead of "reaching for"?
cURL and telnet section added virtual hosting, html and netcat server example section added Apache & Nginx section added finalized topic added myself to contributors - enhanced formulation - fixed some spelling errors - changed examples to target www.opsschool.org
Ok, reformulated some sentences (as a non-native English speaker my wording might be somewhat stiff :-) ) and some spelling mistakes (similarly, I read over small spelling errors quite rapidly..) |
@miketheman @adrianmoisey I've addressed your comments and squashed into a single commit. |
Some implementations might interpret a request without ``Host`` header as invalid, and respond with the ``400 Bad Request`` message. | ||
An empty line indicates the end of the request line and header section. | ||
|
||
The available methods are : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space between "are" and ":"
1 small nitpick comment. |
@bverschueren admirable work! Going to merge, despite the extra space, as I think sphinx will handle that. In case it doesn't, it's a nice PR for someone else to fix in the future. :) |
HTTP 101 (Core protocol) updated
Thanks to @adrianmoisey for helping with review, too! |
No description provided.