Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename public methods for certain consistency #20

Merged
merged 2 commits into from
Mar 2, 2019

Conversation

ilyar
Copy link
Contributor

@ilyar ilyar commented Mar 2, 2019

#16

@codecov
Copy link

codecov bot commented Mar 2, 2019

Codecov Report

Merging #20 into master will increase coverage by 3.42%.
The diff coverage is 82.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   90.32%   93.75%   +3.42%     
==========================================
  Files           6        8       +2     
  Lines         124      160      +36     
==========================================
+ Hits          112      150      +38     
+ Misses         11        6       -5     
- Partials        1        4       +3
Impacted Files Coverage Δ
api/logger.go 100% <ø> (ø)
cmd/template/template.go 100% <ø> (ø) ⬆️
cmd/document/pdf.go 95.12% <100%> (ø) ⬆️
api/routers.go 100% <100%> (ø) ⬆️
api/server.go 100% <100%> (+100%) ⬆️
util/os.go 100% <100%> (ø) ⬆️
api/handlers.go 69.23% <61.53%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8401a3...9fd1518. Read the comment docs.

@ilyar ilyar merged commit c62ecbc into master Mar 2, 2019
@ilyar ilyar deleted the rename-public-methods branch March 2, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant