Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃崡 Description
What does this PR do? Anything folks should know?
This PR merges nested allOf keys (e.g.
allOf: [ { allOf: [...] } ]
)This PR also changes how we handle invalid allOf definitions. Instead of ignoring the
allOf
if there's atype: string
and not flattening allOf, we ignore thetype: string
variant and flatten the rest (assuming there is an object). I think this is likely a better user experience, especially downstream in the rest of our app (e.g. allOf is assumed to not be there, and if it's invalid we'll get things like "every key in the allOf is removed" rule errors).TODO
馃摎 References
Links to relevant docs (Notion, Twist, GH issues, etc.), if applicable.
馃懝 QA
How can other humans verify that this PR is correct?