Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading swagger 2.0 specs #2767

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Support loading swagger 2.0 specs #2767

merged 1 commit into from
Mar 4, 2024

Conversation

niclim
Copy link
Contributor

@niclim niclim commented Mar 1, 2024

馃崡 Description

What does this PR do? Anything folks should know?

Supports loading swagger 2.0 specs - this PR changes all the internal typings to expect a swagger 2, 3 or 3.1 spec but does not support the following commands with swagger 2 specs (swagger 2 code to check is moved to the edges)

  • run
  • dereference or bundle
  • diff or diff-all or lint
  • capture

Things that need to be fixed in follow up PRs

  • update compute.ts (diff) and handle
    • Swagger2 and diff between versions
  • Fix denormalize v2
  • handle validation and denormalize for v2

馃摎 References

Links to relevant docs (Notion, Twist, GH issues, etc.), if applicable.

馃懝 QA

How can other humans verify that this PR is correct?

@niclim niclim requested a review from acunniffe as a code owner March 1, 2024 19:45
@niclim niclim added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit 74f6370 Mar 4, 2024
3 checks passed
@niclim niclim deleted the swagger2-support branch March 4, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants