Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement swagger 2 validation #2772

Merged
merged 1 commit into from
Mar 4, 2024
Merged

implement swagger 2 validation #2772

merged 1 commit into from
Mar 4, 2024

Conversation

niclim
Copy link
Contributor

@niclim niclim commented Mar 4, 2024

馃崡 Description

What does this PR do? Anything folks should know?

馃摎 References

Links to relevant docs (Notion, Twist, GH issues, etc.), if applicable.

馃懝 QA

How can other humans verify that this PR is correct?

@niclim niclim requested a review from acunniffe as a code owner March 4, 2024 18:17
Copy link
Member

@acunniffe acunniffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I got a little confused by the difference between basic and the full schema, but figured out you were using it when strict validation was turned off

@niclim
Copy link
Contributor Author

niclim commented Mar 4, 2024

Looks good. I got a little confused by the difference between basic and the full schema, but figured out you were using it when strict validation was turned off

We have the same idea with the openapi 3 validator, so this is to match the functionality (I think we initially did this to try match the minimum typings) but I could see us moving away to not validate anything here

@niclim niclim added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit 4326649 Mar 4, 2024
3 checks passed
@niclim niclim deleted the handle-validate-v2 branch March 4, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants