-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GenIso.fields #297
Add GenIso.fields #297
Conversation
Benchmark results are in. It's looks to be around 2x ~ 4x faster on average.
|
@@ -1,3 +1,5 @@ | |||
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.5") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you need scalajs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! That's a mistake; I'll remove that.
It looks great but there seems to be an issue with scala 2.10 |
Oops, I didn't even realise that Scala 2.10 was choking and vomiting all over itself with the new macro. Lucky there's TravisCI, and thanks for pointing that out to me. So, I've made the macros work with Scala 2.10, Travis is green and we should be good now. For reference I also opened a macro-compat ticket: milessabin/macro-compat#25 |
Thank you very much! 👍 |
Addresses #295.
Included is a benchmark for comparison with
productToTuple
.I also took the liberty of upgrading JMH from 0.2.4 to 0.2.5 while I was there. Hope that's ok.