Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when n_init < sim_workers #207

Merged
merged 5 commits into from
May 23, 2024
Merged

Fix crash when n_init < sim_workers #207

merged 5 commits into from
May 23, 2024

Conversation

AngelFP
Copy link
Member

@AngelFP AngelFP commented May 7, 2024

Addresses #133.

Problem:

  • Optimas was crashing if n_init (the number of Sobol trials for initialization) is smaller that the number of simulation workers. This is because Ax cannot generate the n_init + 1 trial until at least one of the Sobol trials has finished, and therefore raises an exception.

Solution:

  • Ensure that at least 1 trial is completed before moving from the Sobol to the BO step, and keep generating Sobol trials until that happens, even if the number of Sobol trials exceeds n_init.

@AngelFP AngelFP added the bug Something isn't working label May 7, 2024
@AngelFP AngelFP changed the title [WIP] Fix crash when n_init < sim_workers Fix crash when n_init < sim_workers May 10, 2024
@AngelFP AngelFP requested a review from RemiLehe May 10, 2024 16:56
Copy link
Collaborator

@delaossa delaossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks Angel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants