feat: Use enum to define type in getTypeCastValue (#695)

* Use enum to define type * NIT
optimizely · Jul 27, 2021 · 930c473 · 930c473
1 parent 3d8a5b8
commit 930c473
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/packages/optimizely-sdk/lib/core/project_config/index.ts b/packages/optimizely-sdk/lib/core/project_config/index.ts
@@ -35,7 +35,8 @@ import {
   FeatureVariable,
   Variation,
   OptimizelyVariation,
-  VariationVariable,
+  VariableType,
+  VariationVariable
 } from '../../shared_types';
 
 interface TryCreatingProjectConfigConfig {
@@ -203,7 +204,7 @@ export const createProjectConfig = function(
       // Converting it to a first-class json type while creating Project Config
       feature.variables.forEach((variable) => {
         if (variable.type === FEATURE_VARIABLE_TYPES.STRING && variable.subType === FEATURE_VARIABLE_TYPES.JSON) {
-          variable.type = FEATURE_VARIABLE_TYPES.JSON;
+          variable.type = FEATURE_VARIABLE_TYPES.JSON as VariableType;
           delete variable.subType;
         }
       });
@@ -584,7 +585,7 @@ export const getVariableValueForVariation = function(
  */
 export const getTypeCastValue = function(
   variableValue: string,
-  variableType: string,
+  variableType: VariableType,
   logger: LogHandler
 ): unknown {
   let castValue;

diff --git a/packages/optimizely-sdk/lib/shared_types.ts b/packages/optimizely-sdk/lib/shared_types.ts
@@ -129,8 +129,16 @@ export interface Experiment {
   forcedVariations?: { [key: string]: string };
 }
 
+export enum VariableType {
+  BOOLEAN = 'boolean',
+  DOUBLE = 'double',
+  INTEGER = 'integer',
+  STRING = 'string',
+  JSON = 'json',
+}
+
 export interface FeatureVariable {
-  type: string;
+  type: VariableType;
   key: string;
   id: string;
   defaultValue: string;