Remove redundant lodash core dependency to reduce bundle bloat. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjc1283
added a commit
that referenced
this pull request
Apr 22, 2019
…ager options, and stopping datafile manager (#15) Summary: - Refactor project config management into a ProjectConfigManager class, which uses DatafileManager internally - Update Optimizely to get project config by calling projectConfigManager.getConfig() instead of keeping its own reference to a project config object - Pass through datafileOptions to project config manager (allowing use of autoUpdate and updateInterval) - Add notification center event for new project config - Add an update listener to datafile manager that sends project config update notification - Call this.datafileManager.stop in close method - Add default timeout to onReady method - Update behavior of onReady to reject early when datafile manager emits invalid datafile Test plan: Unit tests Issues: https://optimizely.atlassian.net/browse/OASIS-4385 https://optimizely.atlassian.net/browse/OASIS-4386 https://optimizely.atlassian.net/browse/OASIS-4387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@optimizely/fullstack-devs