fix(track): Batch decision payloads into the same array in the snapshot.

[mikeproeng37]

Before it was many snapshots, each with exactly one decision and one conversion event. This is not accurate because decisions for the experiments attached to the same event should be in the same snapshot.

Only conversion events need to have this special logic, because impression events only come from activate and isFeatureEnabled API (and transitively, getEnabledFeatures), which all submit a single impression event for just one experiment.

[coveralls]

Coverage increased (+0.003%) to 97.114% when pulling 2e8a62c on mng/fix-batch-event-payload into 7ab1195 on master.

[mikeproeng37]

build

[mikeproeng37]

build-e2e

[spencerwilson-optimizely]

Does getImpressionEventParams need this change too?

[spencerwilson-optimizely]

Why is this no longer in the snapshot?

[mikeproeng37]

It is, it gets added on line 154. It's just that instead of having the event duplicated for every decision, we just send one event per snapshot.

[spencerwilson-optimizely]

oh okay cool

[mikeproeng37]

So impression does not need to change because at the moment we only ever activate one experiment at a time instead of batching multiple impressions together. track is special because it loops through each experiment the event is attached to and captures a decision for each.

[spencerwilson-optimizely]

Got it, thanks!

I found the PR name seems kinda misleading, is this name/description accurate?

fix(track): Send all conversion events in one snapshot

Before it was many snapshots, each with exactly one decision and one conversion event. This is wrong because TODO: REASON.

Only conversion events need to have this special logic, because impression events only come from the `activate` and `isFeatureEnabled` APIs (and transitively, `getEnabledFeatures`), which all submit a single impression event for just one experiment. 

edit: I got this wrong, it should be something like 'Send all decisions in the same snapshot as the conversion event' or something.

[spencerwilson-optimizely]

oh okay cool