New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ODP Datafile Parsing #775
feat: ODP Datafile Parsing #775
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A couple of changes suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great! Suggested one change.
@jaeopt , @zashraf1985 - updated to resolve your comments above. Let me know if the solution looks good to you or if I missed anything... thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great!
Summary
Technical Changes
integrations
field to theproject_config_schema
composed of array items which are objects with the keys ofkey
,host
, andpublicKey
.Integrations
ProjectConfig
interface to prepare catching this new incomingintegrations
field:integrations
integrationKeyMap
(Optional)publicKeyForOdp
(Optional)hostForOdp
(Optional)allSegments
getAudienceSegments
function from project_config. This function is used for recursively evaluating through audience conditions qualified matches, returning a concatenated array of all condition values where the conditionmatch
is equal to the valuequalified
.Test plan
getAudienceSegments
works as a standalone function.Issues
Note: Prettier caused many whitespace changes to be applied. To see only the related changes, click the gear icon and select "Hide whitespace changes" in the diff.