Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-922] - un-restrict user attribute type definition, add tests... #923

Closed

Conversation

victor-optimizely
Copy link

Summary

  • Reverts functionality for the type definition on user attributes (allow any type)
  • adds some tests

Test plan

See [#922]

Issues

@coveralls
Copy link

Coverage Status

coverage: 90.327% (+0.01%) from 90.313%
when pulling 5d9b52d on victor-optimizely:issues/922
into 75418da on optimizely:master.

@mikechu-optimizely
Copy link
Contributor

Thanks for the collab. Can I ask your use-case where the specific types are causing problems?

@victor-optimizely
Copy link
Author

victor-optimizely commented Apr 25, 2024

Our team deals with the admin center. We were setting the user's current instance object as a value here. After further investigation we are no longer using any of the fields in the object and moving forward we can just set the specific field we'll use. Since we're updating from 2.X -> 3.X a breaking change is expected I will close this in favor of the documentation being updated. Thanks for looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants