Fix vulnerabilities by removing request dependency #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: [`srcclr`](https://optimizely.sourceclear.io/teams/3OOu2k/scans/3772139?login=saml) flags `request` and some of its transitive dependencies as vulnerable. Since we are only barely using it, we can switch to the native node modules `http`/`https` instead. The result is a [[ https://optimizely.sourceclear.io/teams/3OOu2k/scans/3772270?login=saml | clean run ]]! ``` $ srcclr scan . SourceClear scanning engine ready Running the NPM scanner Scanning completed Found 12997 lines of code Processing results... Processing results complete Summary Report Scan ID 614c7376-d1ae-4d77-ad5f-3078f6a17917 Scan Date & Time May 16 2018 04:26PM PDT Account type PRO Scan engine 2.14.7 (latest 2.14.7) Analysis time 12 seconds User tbrandt Project /Users/tbrandt/optly/Projects/javascript-sdk/packages/optimizely-sdk Package Manager(s) NPM Open-Source Libraries Total Libraries 5 Direct Libraries 5 Transitive Libraries 0 Vulnerable Libraries 0 Third Party Code 77.4% Security With Vulnerable Methods 0 High Risk Vulnerabilities 0 Medium Risk Vulnerabilities 0 Low Risk Vulnerabilities 0 Licenses Unique Library Licenses 3 Libraries Using GPL 0 Libraries With No License 1 Libraries With Multiple Licenses 1 Full Report Details https://optimizely.sourceclear.io/teams/3OOu2k/scans/3772270?login=saml ``` Also add srcclr.yml with `scope: production` so we can scan more easily in the correct way. Test Plan: Existing automated tests Reviewers: matt.carroll, ola.nordstrom, michael.hood, ali, greeshma Reviewed By: ali, greeshma JIRA Issues: OASIS-2776 Differential Revision: https://phabricator.optimizely.com/D19829
added 3 commits
May 18, 2018 11:49
| @@ -25,23 +25,42 @@ module.exports = { | |||
| * @param {Object} eventObj.params parameters to pass to the request | |||
| * @param {string} eventObj.httpVerb the HTTP request method type | |||
| * @param {function} callback callback to execute | |||
| * @return {Promise<Object>} the payload from the request | |||
| * @return {ClientRequest} ClientRequest object which made the request | |||
There was a problem hiding this comment.
Should we also document that we return undefined if the req is non POSt? Or we can return an explicit null in that case as well
There was a problem hiding this comment.
Yeah, I'll update this
mikeproeng37
approved these changes
May 21, 2018
.travis.yml
Outdated
| @@ -3,7 +3,8 @@ node_js: | |||
| - '4' | |||
| - '6' | |||
| - '8' | |||
| - node | |||
| - '9' | |||
| - '10' | |||
There was a problem hiding this comment.
Looks like Node 10 might be causing issues?
There was a problem hiding this comment.
Yeah, I was talking about it with @aliabbasrizvi on Friday. It's affecting master as well (https://travis-ci.org/optimizely/javascript-sdk/builds/380812924), hence the other PR #101
added 3 commits
May 21, 2018 10:00
# Conflicts: # .travis.yml
|
Did some manual testing and counting by creating a new A/B experiment and a Feature Experiment. Verified that impressions and conversion events with revenue show up correctly in our Results Dashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
srcclrflagsrequestand some of its transitive dependencies as vulnerable. Since we are only barely using it, we can switch to the native node moduleshttp/httpsinstead. The result is a clean run.Also add srcclr.yml with
scope: productionso we can scan more easily in the correct way.Test Plan: Existing automated tests
Reviewers: matt.carroll, ola.nordstrom, michael.hood, ali, greeshma
Reviewed By: ali, greeshma
JIRA Issues: OASIS-2776
Differential Revision: https://phabricator.optimizely.com/D19829