fix(event flush): Setting unit of time correctly (#219)

optimizely · Oct 25, 2019 · 955712b · 955712b
1 parent b834b1d
commit 955712b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/optimizely/event/event_processor.py b/optimizely/event/event_processor.py
@@ -95,12 +95,12 @@ def __init__(self,
                             if self._validate_instantiation_props(flush_interval,
                                                                   'flush_interval',
                                                                   self._DEFAULT_FLUSH_INTERVAL) \
-                            else timedelta(self._DEFAULT_FLUSH_INTERVAL)
+                            else timedelta(seconds=self._DEFAULT_FLUSH_INTERVAL)
     self.timeout_interval = timedelta(seconds=timeout_interval) \
                               if self._validate_instantiation_props(timeout_interval,
                                                                     'timeout_interval',
                                                                     self._DEFAULT_TIMEOUT_INTERVAL) \
-                              else timedelta(self._DEFAULT_TIMEOUT_INTERVAL)
+                              else timedelta(seconds=self._DEFAULT_TIMEOUT_INTERVAL)
 
     self.notification_center = notification_center or _notification_center.NotificationCenter(self.logger)
     self._current_batch = list()

diff --git a/tests/test_event_processor.py b/tests/test_event_processor.py
@@ -327,7 +327,7 @@ def test_init__invalid_flush_interval(self):
       )
 
     # default flush interval is 30s.
-    self.assertEqual(datetime.timedelta(30), self.event_processor.flush_interval)
+    self.assertEqual(datetime.timedelta(seconds=30), self.event_processor.flush_interval)
     mock_config_logging.info.assert_called_with('Using default value 30 for flush_interval.')
 
   def test_init__bool_flush_interval(self):
@@ -345,7 +345,7 @@ def test_init__bool_flush_interval(self):
       )
 
     # default flush interval is 30s.
-    self.assertEqual(datetime.timedelta(30), self.event_processor.flush_interval)
+    self.assertEqual(datetime.timedelta(seconds=30), self.event_processor.flush_interval)
     mock_config_logging.info.assert_called_with('Using default value 30 for flush_interval.')
 
   def test_init__string_flush_interval(self):
@@ -363,7 +363,7 @@ def test_init__string_flush_interval(self):
       )
 
     # default flush interval is 30s.
-    self.assertEqual(datetime.timedelta(30), self.event_processor.flush_interval)
+    self.assertEqual(datetime.timedelta(seconds=30), self.event_processor.flush_interval)
     mock_config_logging.info.assert_called_with('Using default value 30 for flush_interval.')
 
   def test_init__invalid_timeout_interval(self):
@@ -381,7 +381,7 @@ def test_init__invalid_timeout_interval(self):
       )
 
     # default timeout interval is 5s.
-    self.assertEqual(datetime.timedelta(5), self.event_processor.timeout_interval)
+    self.assertEqual(datetime.timedelta(seconds=5), self.event_processor.timeout_interval)
     mock_config_logging.info.assert_called_with('Using default value 5 for timeout_interval.')
 
   def test_init__NaN_timeout_interval(self):
@@ -399,7 +399,7 @@ def test_init__NaN_timeout_interval(self):
       )
 
     # default timeout interval is 5s.
-    self.assertEqual(datetime.timedelta(5), self.event_processor.timeout_interval)
+    self.assertEqual(datetime.timedelta(seconds=5), self.event_processor.timeout_interval)
     mock_config_logging.info.assert_called_with('Using default value 5 for timeout_interval.')
 
   def test_notification_center__on_log_event(self):