Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(event flush): Setting unit of time correctly #219

Merged
merged 2 commits into from
Oct 25, 2019
Merged

fix(event flush): Setting unit of time correctly #219

merged 2 commits into from
Oct 25, 2019

Conversation

aliabbasrizvi
Copy link
Contributor

It should be seconds as expected

@aliabbasrizvi aliabbasrizvi requested a review from a team as a code owner October 25, 2019 20:08
mikeproeng37
mikeproeng37 approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aliabbasrizvi aliabbasrizvi removed their assignment Oct 25, 2019
@coveralls
Copy link

coveralls commented Oct 25, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 97.646% when pulling 3c72169 on ali/fix_cleaning into b834b1d on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.646% when pulling 3c72169 on ali/fix_cleaning into b834b1d on master.

@aliabbasrizvi aliabbasrizvi merged commit 955712b into master Oct 25, 2019
@aliabbasrizvi aliabbasrizvi deleted the ali/fix_cleaning branch October 25, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aliabbasrizvi @coveralls @mikeproeng37