Refactoring and passing ProjectConfig from Optimizely itself. #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 similar comments
aliabbasrizvi
commented
May 15, 2019
| @@ -1960,23 +1963,23 @@ def test_get_enabled_features__broadcasts_decision_for_each_feature(self): | |||
| mock_variation_2 = opt_obj.config.get_variation_from_id('test_experiment', '111128') | |||
|
|
|||
| def side_effect(*args, **kwargs): | |||
| feature = args[0] | |||
| feature = args[1] | |||
There was a problem hiding this comment.
This had to change as project_config is first param (index 0) now.
mjc1283
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ProjectConfigvs every class having its own copy ofProjectConfig. This wayBucketer,DecisionServiceandEventBuilderare static and makes way for us to introduce datafile manager.Test plan
Unit tests and compatibility suite tests continue to pass.