-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sphinx setup #242
Merged
Merged
Sphinx setup #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavorona
force-pushed
the
pnguen/sphinx_setup
branch
from
March 26, 2020 21:22
510cad7
to
45b5275
Compare
aliabbasrizvi
suggested changes
Mar 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to just have sphinx in requirements as part of this initial PR.
yavorona
force-pushed
the
pnguen/sphinx_setup
branch
from
March 26, 2020 23:57
45b5275
to
223aea8
Compare
4 similar comments
aliabbasrizvi
approved these changes
Mar 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yavorona
added a commit
that referenced
this pull request
May 12, 2020
Co-authored-by: Polina Nguen <polina.nguen@optimizely.com>
yavorona
added a commit
that referenced
this pull request
May 14, 2020
Co-authored-by: Polina Nguen <polina.nguen@optimizely.com>
yavorona
added a commit
that referenced
this pull request
May 14, 2020
* Add docs.txt to requirements (#242) Co-authored-by: Polina Nguen <polina.nguen@optimizely.com> * Create script to generate html docs with sphinx (#243) * Create script to generate html docs with sphinx Add minor changes to README.md and CONTRIBUTING.md for proper conversion to .rst * Address comments * Clean up Co-authored-by: Polina Nguen <polina.nguen@optimizely.com> * Include docstrings from bucketer.py and decision_service.py to the docs (#244) * Include docstrings from bucketer.py and decision_service.py to the docs * Fix Travis failure Co-authored-by: Polina Nguen <polina.nguen@optimizely.com> * Add docstrings from config_manager.py and optimizely_config.py to docs (#245) Update buckering_algorithm to exclude namedtuble docstrings Co-authored-by: Polina Nguen <polina.nguen@optimizely.com> * Added optimizely.py, event_dispatcher.py, and event_builder.py docstrings to the docs (#246) * Added optimizely.py to docs * Returned to having private methods included for now. * Added optimizely.py, event_builder.py, and event_dispatcher.py to the docs Co-authored-by: Polina Nguen <polina.nguen@optimizely.com> * Added logger.py and user_profile.py docstrings to the docs. (#247) * Added optimizely.py to docs * Returned to having private methods included for now. * Added optimizely.py, event_builder.py, and event_dispatcher.py to the docs * Added user_profile.py and logger.py docstrings to docs Moved all api_reference components into one rst file Co-authored-by: Polina Nguen <polina.nguen@optimizely.com> * Adding version of python sdk to docs (#249) * Added optimizely.py to docs * Returned to having private methods included for now. * Added optimizely.py, event_builder.py, and event_dispatcher.py to the docs * Add version to docs * Update branch Co-authored-by: Polina Nguen <polina.nguen@optimizely.com> * Remove private methods (#250) * Update sphinx docs per OASIS-6317 (#252) * Change pip8 to flake8 * Update contributing link to work in sphinx docs * Remove Event Builder * Change “Bucketing Algorithm Methods” to “Bucketing” * Update project name * Include README to table of contents * Create readme.rst for readme.md * Add Optimizely logo to docs (#256) * [OASIS-6317] - Fix README.md format (#255) * Fix table in Advanced configuration * Fix anchor * Added README.md for generating sphinx docs (#257) * Create README for sphinx docs * Fix spelling * Update README.md Add title * Incorporate Ali's comments * chore(build): Making sure docs is excluded from build (#258) * Removed Bucketing Algorithm Section and Added Description of Class Init Options in class Optimizely (#259) * Remove bucketing algorithm section * Add __init__ to class optimizely.optimizely.Optimizely * Specified master_doc Co-authored-by: Ali Abbas Rizvi <aliabbasrizvi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues