Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement get_all_feature_variables and get_feature_variable_json #251

Merged
merged 5 commits into from
Apr 24, 2020
Merged

feat: Implement get_all_feature_variables and get_feature_variable_json #251

merged 5 commits into from
Apr 24, 2020

Conversation

pawels-optimizely
Copy link
Contributor

Summary

  • implement get_all_feature_variables and get_feature_variable_json public APIs
  • created and adjusted unit tests

@pawels-optimizely pawels-optimizely requested a review from a team as a code owner April 21, 2020 07:43
@pawels-optimizely pawels-optimizely self-assigned this Apr 21, 2020
@coveralls
Copy link

coveralls commented Apr 21, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.6%) to 97.097% when pulling 702ff3f on pawel/OASIS-6195 into 167758d on master.

@pawels-optimizely pawels-optimizely removed their assignment Apr 21, 2020
aliabbasrizvi
aliabbasrizvi suggested changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to revisit notification listener implementation. It should be analogous to get_enabled_features

optimizely/optimizely.py Outdated Show resolved Hide resolved
optimizely/optimizely.py Outdated Show resolved Hide resolved
optimizely/project_config.py Show resolved Hide resolved
tests/base.py Show resolved Hide resolved
aliabbasrizvi
aliabbasrizvi reviewed Apr 22, 2020
View reviewed changes
optimizely/helpers/enums.py Outdated Show resolved Hide resolved
optimizely/optimizely.py
attributes: Dict representing user attributes.

Returns:
Dictionary of all variables. None if:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we return empty dict? Or you think that denotes no variables are associated with the feature?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still should return None - that way we are being consistent with _get_feature_variable_for_type()

optimizely/optimizely.py Outdated Show resolved Hide resolved
optimizely/optimizely.py Outdated Show resolved Hide resolved
optimizely/optimizely.py Outdated Show resolved Hide resolved
@pawels-optimizely pawels-optimizely removed their assignment Apr 23, 2020
aliabbasrizvi
aliabbasrizvi approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pawels-optimizely pawels-optimizely merged commit 1ca4fca into master Apr 24, 2020
@pawels-optimizely pawels-optimizely deleted the pawel/OASIS-6195 branch April 24, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

@msohailhussain msohailhussain Awaiting requested review from msohailhussain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pawels-optimizely @coveralls @aliabbasrizvi