Duplicate experiment Key issue with multi feature flag #347
Conversation
…D instead of key to resolve bug
…than the other way around.
| @@ -41,6 +41,7 @@ def test_init(self): | |||
| self.config_dict['groups'][0]['trafficAllocation'], | |||
| ) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
we need a new line to satisfy Flake8
|
Flake8 needs to be fixed... has both best practice and anti-pattern flagged so no winning: ./optimizely/project_config.py:577:17: W504 line break after binary operator |
|
@msohailhussain If you can give the final OK, I can then merge to Master. |
| @@ -1,5 +1,5 @@ | |||
| [flake8] | |||
| # E722 - do not use bare 'except' | |||
| ignore = E722 | |||
| ignore = E722, W504 | |||
There was a problem hiding this comment.
can you please explain in the comments, why W504 added.
There was a problem hiding this comment.
comment added explaining the reason for W504.
optimizely/project_config.py
Outdated
| @@ -557,3 +566,35 @@ def is_feature_experiment(self, experiment_id): | |||
| """ | |||
|
|
|||
| return experiment_id in self.experiment_feature_map | |||
|
|
|||
| def get_variation_from_id_by_experiment_id(self, experiment_id, variation_id): | |||
| """ Gets experiment id and variation id | |||
There was a problem hiding this comment.
Gets only variation by variation id under specific experiment id.
There was a problem hiding this comment.
comments changed to better describe what is happening.
optimizely/project_config.py
Outdated
| return {} | ||
|
|
||
| def get_variation_from_key_by_experiment_id(self, experiment_id, variation_key): | ||
| """ Gets experiment id and variation key |
There was a problem hiding this comment.
please rephrase and have more clear explanation.
There was a problem hiding this comment.
comments changed to better describe what is happening.
|
FSC Link for passing new cases: https://travis-ci.com/github/optimizely/fullstack-sdk-compatibility-suite/builds/232344687 |
* Changing lookup of experiment in decision service to use experiment ID instead of key to resolve bug * [BUGFIX] - Update to bucketer and added proper ID map to project_config. * Switch to generate experiments_key_map from experiment_id_map rather than the other way around. * Updated with unit tests. * Change line break before operator to avoid W504 Flake8 issue. * Flake8 changes to follow best practice and ignore the W504
* Changing lookup of experiment in decision service to use experiment ID instead of key to resolve bug * [BUGFIX] - Update to bucketer and added proper ID map to project_config. * Switch to generate experiments_key_map from experiment_id_map rather than the other way around. * Updated with unit tests. * Change line break before operator to avoid W504 Flake8 issue. * Flake8 changes to follow best practice and ignore the W504
Summary
Test plan
Issues