Skip to content

Commit

Permalink
Merge pull request #884 from porink0424/feat/add-type-check-to-standa…
Browse files Browse the repository at this point in the history
…loneapp

Add type-checks on `standalone_app`
  • Loading branch information
c-bata committed Jun 4, 2024
2 parents cffc86d + da5f81d commit 3091ed1
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 3 deletions.
16 changes: 14 additions & 2 deletions .github/workflows/typescript-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- run: npm run lint

type-check:
name: Type checking on optuna-dashboard
name: Type checking on optuna-dashboard & standalone_app
runs-on: ubuntu-latest

steps:
Expand All @@ -44,12 +44,24 @@ jobs:
- name: Setup tslib
run: make tslib

- name: Type Check
- name: Type Check optuna_dashboard
working-directory: optuna_dashboard
run: |
npm install
npm run type-check
- name: Build rustlib for standalone_app
working-directory: rustlib
run: |
curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh
wasm-pack build --target web
- name: Type Check standalone_app
working-directory: standalone_app
run: |
npm install
npm run type-check
check-package-lock-json:
name: Check package-lock.json
runs-on: ubuntu-latest
Expand Down
3 changes: 2 additions & 1 deletion standalone_app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"description": "",
"scripts": {
"watch": "vite",
"build:vscode": "webpack"
"build:vscode": "webpack",
"type-check": "tsc --noEmit"
},
"devDependencies": {
"@optuna/types": "../tslib/types",
Expand Down

0 comments on commit 3091ed1

Please sign in to comment.