Skip to content

Commit

Permalink
Merge pull request #863 from porink0424/fix/type-replace
Browse files Browse the repository at this point in the history
Align the types defined in `optuna_dashboard/ts` to `@optuna/types` as much as possible
  • Loading branch information
c-bata committed Apr 17, 2024
2 parents 708ae8c + c4ba65a commit eb6c79e
Show file tree
Hide file tree
Showing 54 changed files with 591 additions and 1,286 deletions.
23 changes: 23 additions & 0 deletions .github/workflows/typescript-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,32 @@ jobs:
uses: actions/setup-node@v2
with:
node-version: '20'

- run: npm install
- run: npm run lint

type-check:
name: Type checking on optuna-dashboard
runs-on: ubuntu-latest

steps:
- name: Check out code
uses: actions/checkout@master

- name: Setup Node
uses: actions/setup-node@v2
with:
node-version: '20'

- name: Setup tslib
run: make tslib

- name: Type Check
working-directory: optuna_dashboard
run: |
npm install
npm run type-check
build:
name: JS build check
runs-on: ubuntu-latest
Expand Down
3 changes: 2 additions & 1 deletion biome.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"ignore": [
"optuna_dashboard/ts/components/PlotlyColorTemplates.ts",
"tslib/react/src/components/PlotlyDarkMode.ts",
"tslib/**/pkg/*"
"tslib/**/pkg/*",
"tslib/react/types/*"
]
},
"javascript": {
Expand Down
2 changes: 1 addition & 1 deletion optuna_dashboard/_serializer.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"type": Literal["FloatDistribution"],
"low": float,
"high": float,
"step": float,
"step": Union[float, None],
"log": bool,
},
)
Expand Down

0 comments on commit eb6c79e

Please sign in to comment.