Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the types defined in optuna_dashboard/ts to @optuna/types as much as possible #863

Merged
merged 24 commits into from
Apr 17, 2024

Conversation

porink0424
Copy link
Collaborator

@porink0424 porink0424 commented Apr 12, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

NA

What does this implement/fix? Explain your changes.

  • Aligned the types defined in optuna_dashboard/ts to @optuna/types as much as possible
  • type-check run script added for checking types
  • Added type-check into github workflow

@porink0424 porink0424 marked this pull request as draft April 12, 2024 10:03
@c-bata c-bata self-assigned this Apr 15, 2024
@porink0424 porink0424 marked this pull request as ready for review April 17, 2024 06:35
package.json Outdated
Comment on lines 4 to 6
"lint": "npm run lint:eslint && npm run lint:biome && cd optuna_dashboard && npm run lint",
"lint:eslint": "eslint . --ext .ts,.tsx --max-warnings 0",
"lint:biome": "biome format . && biome ci standalone_app vscode tslib"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: How about calling npm run type-check directrly?

Suggested change
"lint": "npm run lint:eslint && npm run lint:biome && cd optuna_dashboard && npm run lint",
"lint:eslint": "eslint . --ext .ts,.tsx --max-warnings 0",
"lint:biome": "biome format . && biome ci standalone_app vscode tslib"
"lint": "npm run lint:eslint && npm run lint:biome && npm run lint:tsc",
"lint:eslint": "eslint . --ext .ts,.tsx --max-warnings 0",
"lint:biome": "biome format . && biome ci standalone_app vscode tslib"
"lint:tsc": "cd optuna_dashboard && npm run type-check"

Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@c-bata c-bata merged commit eb6c79e into optuna:main Apr 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants