plot intermediate values of running trials #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshinobc
changed the title
c-bata
reviewed
May 6, 2022
There was a problem hiding this comment.
Hi @yoshinobc! Thank you for your pull request. I leave a review comment 🙇
yoshinobc
commented
May 6, 2022
c-bata
reviewed
May 11, 2022
| @@ -55,7 +55,7 @@ export const actionCreator = () => { | |||
| studyId in studyDetails | |||
| ? studyDetails[studyId].trials.slice(0, nLocalFixedTrials) | |||
| : [] | |||
| study.trials = study.trials.concat(currentFixedTrials) | |||
| study.trials = currentFixedTrials.concat(study.trials) | |||
There was a problem hiding this comment.
Oh, sorry. Now I understand what you said. Your changes looks perfect 💯
c-bata
reviewed
May 11, 2022
c-bata
reviewed
May 11, 2022
|
Let me merge this PR with two suggested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
This PR fix #92
What does this implement/fix? Explain your changes.
Motivation
plot intermediate values of running trials
Description of the changes
GraphIntermediateValues.tsx