Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot contour graph in backend #764

Merged
merged 9 commits into from
Jan 26, 2024
Merged

Plot contour graph in backend #764

merged 9 commits into from
Jan 26, 2024

Conversation

knshnb
Copy link
Member

@knshnb knshnb commented Jan 23, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

We experimentally introduce a backend rendering of graphs by using optuna.visualization as a possible substitution for frontend rendering, which is becoming a large codebase and is getting hard to maintain.
Ref: #156

What does this implement/fix? Explain your changes.

Use optuna.visualization.plot_contour for the contour plot when plotlypy_rendering=true is specified as a query parameter.

We will make this feature available to users (e.g., by preference panels) after we support the backend rendering of some other graphs.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9b2e894) 69.48% compared to head (aef91de) 69.38%.
Report is 30 commits behind head on main.

Files Patch % Lines
optuna_dashboard/_app.py 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
- Coverage   69.48%   69.38%   -0.11%     
==========================================
  Files          35       35              
  Lines        2353     2368      +15     
==========================================
+ Hits         1635     1643       +8     
- Misses        718      725       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-bata c-bata self-assigned this Jan 24, 2024
@knshnb knshnb changed the title Contour backend Plot contour in backend Jan 26, 2024
@knshnb knshnb changed the title Plot contour in backend Plot contour graph in backend Jan 26, 2024
@knshnb knshnb marked this pull request as ready for review January 26, 2024 06:45
Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c-bata c-bata merged commit 8033e79 into optuna:main Jan 26, 2024
18 checks passed
@knshnb knshnb mentioned this pull request Feb 2, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants