Resolve plotly.py dependency issue #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-bata
approved these changes
Jan 26, 2024
Comment on lines
+29
to
+38
| const plotlypyIsAvailable = useRecoilValue<boolean>(plotlypyIsAvailableState) | ||
| if (query.get("plotlypy_rendering") === "true") { | ||
| return <ContourBackend study={study} /> | ||
| if (plotlypyIsAvailable) { | ||
| return <ContourBackend study={study} /> | ||
| } else { | ||
| console.warn( | ||
| "Use frontend rendering because plotlypy is specified but not available." | ||
| ) | ||
| return <ContourFrontend study={study} /> | ||
| } |
There was a problem hiding this comment.
Perhaps, we could define the following wrapper function in state.ts:
export const usePlotlypyIsAvailable = (): boolean => {
const query = useQuery()
const plotlypyIsAvailable = useRecoilValue<boolean>(plotlypyIsAvailableState)
if (query.get("plotlypy_rendering") === "true") {
if (plotlyPyIsAvailable) {
return true
}
console.warn(...)
}
return false
}There was a problem hiding this comment.
Furthermore, we could use notistack to show a warning message to users like below:
optuna-dashboard/optuna_dashboard/ts/action.ts
Lines 234 to 236 in 8033e79
There was a problem hiding this comment.
Yeah, I will introduce this function when I implement backend rendering of other graphs 👍
|
Thanks for the review! I worked on #773 (comment) by another PR: #778. Let me merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
Follow-up of #764
What does this implement/fix? Explain your changes.