-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align the types defined in optuna_dashboard/ts
to @optuna/types
as much as possible
#863
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
44ab51c
Add run scripts
porink0424 918d9f0
Resolve type errors
porink0424 2dd2427
Remove type TrialValueNumber
porink0424 59af374
Remove type TrialIntermediateValueNumber
porink0424 7678a12
Remove from StudyDirection
porink0424 f8b0a9a
Modify CategoricalDistribution choices type to
porink0424 e03910a
Add devDependencies of @optuna/types
porink0424 e55212a
Remove common types from optuna_dashboard
porink0424 2836969
Apply formatter
porink0424 76622bb
Tiny fix for lint
porink0424 8d899e2
Fix the type of IntDistribution.step
porink0424 9e3eb49
Fix the type in serializer
porink0424 1080b8a
Update type def file
porink0424 e531f1e
Apply formatter
porink0424 cf591d0
Move some types from input.d.ts -> optuna.ts
porink0424 e887710
Delete
porink0424 958045e
Merge branch 'main' of github.com:porink0424/optuna-dashboard into fi…
porink0424 9181142
Add package-lock.json
porink0424 555438e
Add type-check into lint flow
porink0424 abff6e0
Add 'make tslib' flow into Lint checking
porink0424 c59daa1
Update biome config
porink0424 0dcd553
Add type-check test into github workflow
porink0424 e34dd05
Replace target es5 -> es6 in tsconfig
porink0424 c4ba65a
Update package-lock.json
porink0424 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: How about calling
npm run type-check
directrly?