Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make biome-linter ignore ts files in optuna_dashboard #866

Merged
merged 7 commits into from
Apr 19, 2024

Conversation

porink0424
Copy link
Collaborator

@porink0424 porink0424 commented Apr 19, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

NA

What does this implement/fix? Explain your changes.

TS files in optuna_dashboard used to be double checked by biome-linter and eslint. I made an update that makes biome-linter ignore those files so that only eslint checks them.

Also, in the script npm run fmt, I added organizeImport into optuna_dashboard.

@c-bata
Copy link
Member

c-bata commented Apr 19, 2024

@porink0424 Could you fix the following error?

$ npm run lint

> lint
> npm run lint:eslint && npm run lint:biome


> lint:eslint
> eslint . --ext .ts,.tsx --max-warnings 0

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.3.5 <5.4.0

YOUR TYPESCRIPT VERSION: 5.4.2

Please only submit bug reports when using the officially supported version.

=============

> lint:biome
> biome format . && biome ci .

./biome.json format ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ✖ Formatter would have printed the following content:

    21 21 │     },
    22 22 │     "linter": {
    23    │ - → → "ignore":·[
    24    │ - → → → "optuna_dashboard/ts/**/*.ts",
    25    │ - → → → "optuna_dashboard/ts/**/*.tsx"
    26    │ - → → ]
       23 │ + → → "ignore":·["optuna_dashboard/ts/**/*.ts",·"optuna_dashboard/ts/**/*.tsx"]
    27 24 │     },
    28 25 │     "javascript": {


Checked 99 files in 1129ms. No fixes needed.
Found 1 error.
format ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ✖ Some errors were emitted while running checks.

@porink0424 porink0424 changed the title Make biome-linter ignore ts files in optuna_dashboard Make biome-linter ignore ts files in optuna_dashboard Apr 19, 2024
@c-bata c-bata merged commit f58f306 into optuna:main Apr 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants