New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify simple examples based on the Optuna code conventions #218
Modify simple examples based on the Optuna code conventions #218
Conversation
2953993
to
f9272ee
Compare
This pull request has not seen any recent activity. |
|
Thank you! |
@Alnusjaponica Could you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM, though I made some minor comments.
@toshihikoyanase Do you have any additional comments?
multi_objective/quadratic_simple.py
Outdated
In this example, we optimize simple quadratic functions. | ||
In this example, we optimize two objective values. | ||
Unlike a single-objective optimization, an optimization gives the trade-off between two objectives. | ||
As a result, we get best trade-offs between two objectives, a.k.a Pareto solutions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess "the" is necessary in this case. Feel free to ignore this comment when you don't agree with it.
As a result, we get best trade-offs between two objectives, a.k.a Pareto solutions. | |
As a result, we get the best trade-offs between two objectives, a.k.a Pareto solutions. |
quadratic_simple_constraint.py
Outdated
print("All trials violated the constraints.") | ||
print("Number of finished trials: ", len(study.trials)) | ||
|
||
feasible_trial_ids = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to avoid using the word id
since trial.trial_id
and trial.number
are different. How about using other words such as numbers
or idx
instead.
@Alnusjaponica Thank you for your thorough review. I have no further comments, so please merge after your review. |
de32944
to
3724cf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
This PR refactors PR#216.
Primary changes in this PR is to modify the codes so that the examples will follow the Optuna code conventions.
Description of the changes
The typical code conventions are the following:
obj1
,obj2
, and