Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Keras docs #12

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Fix Keras docs #12

merged 2 commits into from
Apr 14, 2023

Conversation

HideakiImamura
Copy link
Member

Motivation

Fix the documentation of Keras

Description of the changes

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@8a7573d). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage        ?   64.20%           
=======================================
  Files           ?        3           
  Lines           ?      257           
  Branches        ?        0           
=======================================
  Hits            ?      165           
  Misses          ?       92           
  Partials        ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Alnusjaponica
Copy link
Contributor

I already made the same change in #8 (See this commit). Should I revert this?

@HideakiImamura
Copy link
Member Author

@Alnusjaponica Yes, I think this change should be merged on its own.

@gen740 Could you review this PR?

@Alnusjaponica
Copy link
Contributor

I see. I changed #12 accordingly.

Copy link
Collaborator

@gen740 gen740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gen740 gen740 merged commit 0883e81 into optuna:main Apr 14, 2023
14 checks passed
@HideakiImamura HideakiImamura added the document Documentation related. label May 18, 2023
@HideakiImamura HideakiImamura added this to the v3.2.0 milestone May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants