Move integration/allennlp
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+26
to
+28
| optuna.integration.AllenNLPExecutor | ||
| optuna.integration.allennlp.dump_best_config | ||
| optuna.integration.AllenNLPPruningCallback |
There was a problem hiding this comment.
These modules are listed inside the Chainer section. I think we should create the AllenNLP section.
gen740
reviewed
Apr 7, 2023
README.md
Outdated
| * [Chainer](https://optuna.readthedocs.io/en/stable/reference/integration.html#chainer) ([example](https://github.com/optuna/optuna-examples/tree/main/chainer/chainer_integration.py)) | ||
| * [ChainerMN](https://optuna.readthedocs.io/en/stable/reference/integration.html#chainermn) ([example](https://github.com/optuna/optuna-examples/tree/main/chainer/chainermn_simple.py)) | ||
| * [Keras](https://optuna.readthedocs.io/en/stable/reference/integration.html#keras) ([example](https://github.com/optuna/optuna-examples/tree/main/keras)) | ||
|
|
||
|
|
There was a problem hiding this comment.
This is a bit trivial, but please remove this unnecessary new line.
|
Thank you for your review. I updated the changes accordingly. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #8 +/- ##
=======================================
Coverage ? 76.43%
=======================================
Files ? 9
Lines ? 505
Branches ? 0
=======================================
Hits ? 386
Misses ? 119
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merged
This reverts commit b6c50ee.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Move
integration/allennlpfrom optuna/optunaDescription of the changes
Move
integration/allennlpfrom optuna/optuna