-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn multiple intermediate value reports with the same step. #852
Comments
@sile Hi. Can I take this issue? |
Of course, please go for it! |
@sile |
@stakky Thanks!
I agree with your opinion. I think that it's better to use warnings.warn() instead of Optuna logger. |
Anyway, if you create a (WIP or draft) PR, we can discuss it on the PR. |
This issue has not seen any recent activity. |
Still seems to be an open issue. |
Let me tackle this issue! |
I'm sorry for interrupting but there is no activity on the issue. so i tuckle this issue and create PR. |
Currently, if
trial.report()
method is called multiple times with the same step in a trial, only the first reported value will be recorded into the storage and the others will be silently ignored.Reporting multiple values with the same step is an unintended usage of the method, and it could cause bugs that are hard to notice (see #847 as an example of such bug).
Therefore, it seems better to add a check to detect the duplicate reports, and if it's detected, we should emit a warning message.
As an implementation note, this modification could be done without any additional DB costs (see #847 (comment) for the detail).
The text was updated successfully, but these errors were encountered: