Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plot_param_importances test. #1328

Merged
merged 1 commit into from Jun 8, 2020

Conversation

hvy
Copy link
Member

@hvy hvy commented Jun 5, 2020

Motivation

Unit test for plot_param_importances was fragile as it could fail depending on the evaluated importance (order).

Description of the changes

Fix the test to not consider the order.

@hvy hvy added test Unit test. optuna.visualization Related to the `optuna.visualization` submodule. This is automatically labeled by github-actions. labels Jun 5, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #1328 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1328   +/-   ##
=======================================
  Coverage   86.69%   86.69%           
=======================================
  Files          95       95           
  Lines        7412     7412           
=======================================
  Hits         6426     6426           
  Misses        986      986           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c1b4ca...34b92ff. Read the comment docs.

Copy link
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

[note] We may be able to fix the order of parameters if we carefully design trials, but I feel it is overengineering for these test cases.

@toshihikoyanase toshihikoyanase self-assigned this Jun 5, 2020
@HideakiImamura HideakiImamura self-assigned this Jun 8, 2020
Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HideakiImamura HideakiImamura merged commit 89b5e98 into optuna:master Jun 8, 2020
@hvy hvy deleted the fix-plot-param-importances-test branch June 8, 2020 06:57
@hvy hvy added this to the v2.0.0 milestone Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optuna.visualization Related to the `optuna.visualization` submodule. This is automatically labeled by github-actions. test Unit test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants