Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseStorage.set_trial_intermediate_valute to return None instead of bool. #1337

Merged

Conversation

hvy
Copy link
Member

@hvy hvy commented Jun 8, 2020

Motivation

See #1309.

Description of the changes

Fixes #1309, in particular the following.

  • The storage always sets. The check for "NOOP" is performed by the trial.

@hvy hvy added enhancement Change that does not break compatibility and not affect public interfaces, but improves performance. compatibility Change that breaks compatibility. optuna.storages Related to the `optuna.storages` submodule. This is automatically labeled by github-actions. optuna.trial Related to the `optuna.trial` submodule. This is automatically labeled by github-actions. labels Jun 8, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2020

Codecov Report

Merging #1337 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1337      +/-   ##
==========================================
- Coverage   87.83%   87.79%   -0.04%     
==========================================
  Files          96       96              
  Lines        7300     7301       +1     
==========================================
- Hits         6412     6410       -2     
- Misses        888      891       +3     
Impacted Files Coverage Δ
optuna/storages/base.py 67.59% <ø> (ø)
optuna/storages/cached_storage.py 96.45% <100.00%> (-0.03%) ⬇️
optuna/storages/in_memory.py 97.69% <100.00%> (-0.05%) ⬇️
optuna/storages/rdb/storage.py 93.70% <100.00%> (-0.04%) ⬇️
optuna/storages/redis.py 94.18% <100.00%> (-0.06%) ⬇️
optuna/trial/_trial.py 91.77% <100.00%> (+0.15%) ⬆️
optuna/integration/skopt.py 90.83% <0.00%> (-1.10%) ⬇️
optuna/dashboard.py 60.64% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17093ec...47b7a31. Read the comment docs.

Copy link
Member

@ytsmiling ytsmiling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing #1309. LGTM!

Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM.

@HideakiImamura HideakiImamura merged commit 94dcc83 into optuna:master Jun 9, 2020
@hvy hvy deleted the set-trial-intermediate-value-no-return branch June 9, 2020 10:17
@hvy hvy added this to the v2.0.0 milestone Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Change that breaks compatibility. enhancement Change that does not break compatibility and not affect public interfaces, but improves performance. optuna.storages Related to the `optuna.storages` submodule. This is automatically labeled by github-actions. optuna.trial Related to the `optuna.trial` submodule. This is automatically labeled by github-actions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary return value of BaseStorage.set_trail_intermediate_value.
4 participants