Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set timeout for relatively long-running examples. #1349

Merged
merged 1 commit into from Jun 10, 2020

Conversation

hvy
Copy link
Member

@hvy hvy commented Jun 10, 2020

Motivation

See #1344. Additionally, most examples already utilize this timeout argument, while some are not.

Description of the changes

Use the timeout argument for relatively long-running examples that don't already.

@hvy hvy added the example label Jun 10, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #1349 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1349      +/-   ##
==========================================
- Coverage   87.87%   87.85%   -0.02%     
==========================================
  Files          98       98              
  Lines        7348     7339       -9     
==========================================
- Hits         6457     6448       -9     
  Misses        891      891              
Impacted Files Coverage Δ
optuna/distributions.py 93.68% <0.00%> (-0.31%) ⬇️
optuna/storages/redis.py 94.13% <0.00%> (-0.06%) ⬇️
optuna/storages/rdb/storage.py 93.66% <0.00%> (-0.04%) ⬇️
optuna/storages/in_memory.py 97.66% <0.00%> (-0.03%) ⬇️
optuna/storages/cached_storage.py 96.44% <0.00%> (-0.02%) ⬇️
optuna/storages/base.py 67.59% <0.00%> (ø)
optuna/trial/_trial.py 92.10% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f16121e...a3ea86f. Read the comment docs.

Copy link
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@toshihikoyanase toshihikoyanase added this to the v2.0.0 milestone Jun 10, 2020
@toshihikoyanase toshihikoyanase merged commit a62ef4a into optuna:master Jun 10, 2020
@hvy hvy deleted the examples-timeout-600 branch June 10, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants