Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix to allow building the docs by avoiding latest sphinx. #1369

Merged
merged 1 commit into from Jun 15, 2020

Conversation

hvy
Copy link
Member

@hvy hvy commented Jun 15, 2020

Motivation

Temporary hotfix for #1368.

Description of the changes

Avoids latest sphinx version.

@hvy hvy added the document Documentation related. label Jun 15, 2020
Copy link
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #1369 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1369   +/-   ##
=======================================
  Coverage   87.92%   87.92%           
=======================================
  Files          98       98           
  Lines        7376     7376           
=======================================
  Hits         6485     6485           
  Misses        891      891           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef76b1d...dfad499. Read the comment docs.

Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! LGTM.

@HideakiImamura HideakiImamura merged commit 5940731 into optuna:master Jun 15, 2020
@hvy hvy deleted the fix-sphinx-avoid-311 branch June 15, 2020 00:57
@hvy hvy added this to the v2.0.0 milestone Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants