Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double quotes from Black formatting. #1372

Merged
merged 1 commit into from Jun 15, 2020
Merged

Conversation

Crissman
Copy link
Contributor

Motivation

When Black is compressing two lines together, it sometimes compresses two quotations together, which makes the line less readable.

Description of the changes

Remove the double quotes.

@codecov-commenter
Copy link

Codecov Report

Merging #1372 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1372   +/-   ##
=======================================
  Coverage   87.88%   87.88%           
=======================================
  Files          98       98           
  Lines        7360     7360           
=======================================
  Hits         6468     6468           
  Misses        892      892           
Impacted Files Coverage Δ
optuna/samplers/tpe/sampler.py 86.22% <ø> (ø)
optuna/storages/rdb/storage.py 93.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d043e87...861a1dc. Read the comment docs.

Copy link
Member

@hvy hvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't seen these confusing implicit string concatenations in a while... Good catch and LGTM!

@hvy hvy added this to the v2.0.0 milestone Jun 15, 2020
@hvy hvy added the code-fix Change that does not change the behavior, such as code refactoring. label Jun 15, 2020
@hvy hvy merged commit 7909ae5 into optuna:master Jun 15, 2020
@hvy hvy changed the title Fix double quotes from Black formatting Fix double quotes from Black formatting. Jun 15, 2020
@Crissman Crissman deleted the doubquotes branch June 16, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-fix Change that does not change the behavior, such as code refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants