Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent doc-link from running on unrelated status update events. #1410

Merged
merged 2 commits into from Jun 24, 2020
Merged

Prevent doc-link from running on unrelated status update events. #1410

merged 2 commits into from Jun 24, 2020

Conversation

harupy
Copy link
Contributor

@harupy harupy commented Jun 23, 2020 •
edited

Motivation

Prevnet doc-link from running on unrelated status update events to save GitHub Actions usage.

Description of the changes

Add an if condition to prevent doc-link from running on unrelated events.

@harupy
Copy link
Contributor Author

harupy commented Jun 23, 2020 •
edited

It should look like this once this PR is merged on the master branch:

Screen Shot 2020-06-23 at 20 14 21

https://github.com/harupy/mlflow-extend/actions

@harupy harupy changed the title Prevent doc-link from running on unrelated status update events. Prevent doc-link from running on unrelated status update events Jun 23, 2020
@harupy
Copy link
Contributor Author

harupy commented Jun 23, 2020

The current condition is wrong. I'll fix it.

harupy
harupy commented Jun 23, 2020
View reviewed changes
.github/workflows/doc-link.yml
@@ -5,6 +5,7 @@ on: status
jobs:
doc-link:
runs-on: ubuntu-latest
if: "github.event.context == 'ci/circleci: document'"
Copy link
Contributor Author

@harupy harupy Jun 23, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapped the condition (contains :) with "" to prevent a syntax error.

@HideakiImamura HideakiImamura self-assigned this Jun 24, 2020
@toshihikoyanase toshihikoyanase self-assigned this Jun 24, 2020
toshihikoyanase
toshihikoyanase approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR as always.

I confirmed that the context can be found in the log of CircleCI's webhook, and the change works in your repository as expected.

LGTM.

X-GitHub-Event: status
...
"context": "ci/circleci: document"

@toshihikoyanase toshihikoyanase added the CI Continuous integration. label Jun 24, 2020
HideakiImamura
HideakiImamura approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks as always.

@HideakiImamura HideakiImamura merged commit 4d6e1c7 into optuna:master Jun 24, 2020
@HideakiImamura HideakiImamura added this to the v2.0.0 milestone Jun 24, 2020
@hvy hvy changed the title Prevent doc-link from running on unrelated status update events Prevent doc-link from running on unrelated status update events. Jun 24, 2020
@harupy harupy deleted the skip-doc-link branch June 24, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toshihikoyanase toshihikoyanase toshihikoyanase approved these changes

@HideakiImamura HideakiImamura HideakiImamura approved these changes

Assignees

@toshihikoyanase toshihikoyanase

@HideakiImamura HideakiImamura

Labels
CI Continuous integration.
Projects
None yet
Milestone
v2.0.0-rc0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harupy @toshihikoyanase @HideakiImamura