Apply experimental decorator. #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HideakiImamura
added
the
code-fix
toshihikoyanase
requested changes
Jun 24, 2020
optuna/dashboard.py
Outdated
| def _show_experimental_warning(): | ||
| # type: () -> None | ||
|
|
||
| logger = optuna.logging.get_logger(__name__) | ||
| logger.warning("Optuna dashboard is still highly experimental. Please use with caution!") | ||
| warnings.warn("Optuna dashboard is still highly experimental. Please use with caution!") |
There was a problem hiding this comment.
The message shown in the console is as follows:
optuna/_experimental.py:63: ExperimentalWarning:
_show_experimental_warning is experimental (supported from v0.1.0). The interface can change in the future.
optuna/dashboard.py:264: UserWarning:
Optuna dashboard is still highly experimental. Please use with caution!- I think the target of experimental warning is the dashboard, not
_show_experimental_warning - The warning was divided into two. I think multiple warnings for a single issue may be confusing. Do we add the
textargument to@experimentallike@deprecated?
There was a problem hiding this comment.
Thanks for your comments. I totally agree with you.
- I will specify the
nameargument for the experimental decorator. - I will remove the second warning because it is sufficient here to note the default message of the experimental decorator. BTW, it might be good to give the
textargument to the experimental decorator.
toshihikoyanase
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Apply the experimental decorator to classes which are experimental without the experimental decorator.
Description of the changes
This PR applies the experimental decorator to the following classes:
optuna.dashboardoptuna.integration.sklearn.OptunaSearchCV