Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the experimental warning message for CmaEsSampler. #1432

Conversation

HideakiImamura
Copy link
Member

Motivation

This PR aims to fix the experimental warning message for CmaEsSampler.

Description of the changes

  • Add name = "consider_pruned_trials = True" in CmaEsSampler to the experimental decorator in CmaEsSampler.

Before merging

スクリーンショット 2020-06-25 20 52 07

After merging

スクリーンショット 2020-06-25 20 50 40

@HideakiImamura HideakiImamura added the code-fix Change that does not change the behavior, such as code refactoring. label Jun 25, 2020
Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@hvy hvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, LGTM!

@hvy hvy merged commit 02a8b63 into optuna:master Jun 26, 2020
@hvy hvy added this to the v2.0.0 milestone Jun 26, 2020
@hvy hvy self-assigned this Jun 26, 2020
@HideakiImamura HideakiImamura deleted the code-fix/fix-experimental-message-for-CmaEsSampler branch June 9, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-fix Change that does not change the behavior, such as code refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants