Continue to allow using IntLogUnioformDistribution.step during deprecation.
#1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvy
force-pushed
the
int-log-uniform-dist-allow-step
branch
from
a7f1cb5
to
e37ffa7
Compare
hvy
force-pushed
the
int-log-uniform-dist-allow-step
branch
from
e37ffa7
to
a1db0a3
Compare
optuna/distributions.py
Outdated
Comment on lines
355
to
356
| def __repr__(self): | ||
| # type: () -> str |
There was a problem hiding this comment.
Could you tell me why you use type comments for __repr__ and _asdict?
There was a problem hiding this comment.
Aligned with BaseDistribution. IntLogUniformDistribution as well as this entire module is mixed with modern/comment style type hints, but I aligned the type hints for this class now to modern style. What do you think?
There was a problem hiding this comment.
Thank you for your update. I think we migrate the type hinting gradually, and we can use the new style if we do not have specific reasons.
|
Thanks a lot for the quick review. Comments should be address, PTAL. |
HideakiImamura
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A minor follow-up to #1387 and specifically #1387 (comment).
Description of the changes
Allow users to continue using the
stepattribute ofIntLogUniformDistributionduring deprecation.