Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move css from _templates/footer.html to _static/css/custom.css. #1439

Merged
merged 1 commit into from Jun 26, 2020

Conversation

toshihikoyanase
Copy link
Member

Motivation

Currently, the custom css for the reference is defined in two files, i.e., _templates/footer.html and _static/css/custom.css.
I'd like to integrate them into _static/css/custom.css to improve maintenance costs.

Description of the changes

Move css definitions in _templates/footer.html to _static/css/custom.css.

Copy link
Contributor

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toshihikoyanase
Copy link
Member Author

@harupy Thank you for your swift action!

Copy link
Member

@himkt himkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@hvy hvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me merge this PR as it has several approvals, and it LGTM!

@hvy hvy merged commit 9f5c5cf into optuna:master Jun 26, 2020
@hvy hvy added this to the v2.0.0 milestone Jun 26, 2020
@toshihikoyanase toshihikoyanase deleted the move-css-from-footer branch June 26, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants