Use step to calculate range of IntUniformDistribution in PyCmaSampler.
#1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvy
approved these changes
Jun 30, 2020
toshihikoyanase
force-pushed
the
pycma-update-range-based-on-step
branch
from
508b108
to
ea562f9
Compare
|
Thank you for your review. I resolved the conflict.
Hmm, I think it is |
HideakiImamura
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR derived from #1302 (comment).
Description of the changes
PyCmaSamplerdoes not consider theIntUniformDistribution.stepto calculate the range (i.e.,low,high). I think it is inconsistent with the range calculation forDiscreteUniformDistribution. This PR fixes the range ofIntUniformDistribution.