Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links to examples from the integration references. #1507

Merged
merged 2 commits into from Jul 14, 2020
Merged

Add links to examples from the integration references. #1507

merged 2 commits into from Jul 14, 2020

Conversation

keisuke-umezawa
Copy link
Member

Motivation

Following the other integration references, I added urls to examples.

@codecov-commenter
Copy link

Codecov Report

Merging #1507 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1507   +/-   ##
=======================================
  Coverage   88.81%   88.81%           
=======================================
  Files         104      104           
  Lines        7860     7860           
=======================================
  Hits         6981     6981           
  Misses        879      879
Impacted Files Coverage Δ
optuna/integration/catalyst.py 95.23% <ø> (ø)
optuna/integration/tensorboard.py 87.75% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4915c3a...497e682. Read the comment docs.

hvy
hvy requested changes Jul 13, 2020
View reviewed changes
Copy link
Member

@hvy hvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense for consistency with other integration modules. Left one suggestion.

optuna/integration/catalyst.py Outdated Show resolved Hide resolved
@hvy hvy self-assigned this Jul 13, 2020
@hvy hvy added the document Documentation related. label Jul 13, 2020
@keisuke-umezawa @hvy
Update optuna/integration/catalyst.py
4230da0 
Co-authored-by: Hiroyuki Vincent Yamazaki <hiroyuki.vincent.yamazaki@gmail.com>
hvy
hvy approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@hvy hvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

HideakiImamura
HideakiImamura approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as always. LGTM!

@HideakiImamura HideakiImamura merged commit 27e042e into optuna:master Jul 14, 2020
@hvy hvy added this to the v2.0.0 milestone Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvy hvy hvy approved these changes

@HideakiImamura HideakiImamura HideakiImamura approved these changes

Assignees

@hvy hvy

Labels
document Documentation related.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@keisuke-umezawa @codecov-commenter @hvy @HideakiImamura