Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run daily unit tests. #1515

Merged
merged 1 commit into from Jul 14, 2020
Merged

Run daily unit tests. #1515

merged 1 commit into from Jul 14, 2020

Conversation

hvy
Copy link
Member

@hvy hvy commented Jul 14, 2020

Motivation

It's possible to detect unit test failures due to external factors, such as new releases of depending libraries, faster. Currently, we cannot really detect such failures until for instance a PR is updated to trigger CircleCI/GitHub Actions unit tets.

Follow-up to #1352.

Description of the changes

Adds daily cron triggers to unit tests. The interval is the same as in the stale bot https://github.com/optuna/optuna/blob/master/.github/workflows/stale.yml.

@hvy hvy added the CI Continuous integration. label Jul 14, 2020
Copy link
Member

@himkt himkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot.

@HideakiImamura HideakiImamura merged commit 93aa3dd into optuna:master Jul 14, 2020
@hvy hvy deleted the daily-unit-tests branch July 15, 2020 00:48
@hvy hvy added this to the v2.0.0 milestone Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants