Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwrite parameters correctly. #1518

Merged
merged 2 commits into from Jul 15, 2020
Merged

Overwrite parameters correctly. #1518

merged 2 commits into from Jul 15, 2020

Conversation

ytsmiling
Copy link
Member

Motivation

This PR fixes the storage spec violation that _CachedStorage + RDBStorage does not overwrite parameters. Background of the spec: #1308.

Additional context

This functionality is (currently) never used by users since trial.suggest immediately returns when already-suggested keys are passed to the method.

@ytsmiling ytsmiling added enhancement Change that does not break compatibility and not affect public interfaces, but improves performance. optuna.storages Related to the `optuna.storages` submodule. This is automatically labeled by github-actions. labels Jul 15, 2020
@toshihikoyanase toshihikoyanase self-assigned this Jul 15, 2020
@hvy hvy self-assigned this Jul 15, 2020
hvy
hvy approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@hvy hvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch, LGTM!

@HideakiImamura HideakiImamura self-assigned this Jul 15, 2020
@hvy
Copy link
Member

hvy commented Jul 15, 2020

Resolved conflicts.

@hvy hvy added this to the v2.0.0 milestone Jul 15, 2020
HideakiImamura
HideakiImamura approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

toshihikoyanase
toshihikoyanase approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@toshihikoyanase toshihikoyanase merged commit dd126b9 into optuna:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toshihikoyanase toshihikoyanase toshihikoyanase approved these changes

@hvy hvy hvy approved these changes

@HideakiImamura HideakiImamura HideakiImamura approved these changes

Assignees

@toshihikoyanase toshihikoyanase

@hvy hvy

@HideakiImamura HideakiImamura

Labels
enhancement Change that does not break compatibility and not affect public interfaces, but improves performance. optuna.storages Related to the `optuna.storages` submodule. This is automatically labeled by github-actions.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ytsmiling @hvy @toshihikoyanase @HideakiImamura