Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs of default importance evaluator. #1524

Merged
merged 1 commit into from Jul 16, 2020
Merged

Update docs of default importance evaluator. #1524

merged 1 commit into from Jul 16, 2020

Conversation

hvy
Copy link
Member

@hvy hvy commented Jul 15, 2020

Motivation

Fixes #1523.

Description of the changes

Updates the documentation about the default importance evaluator to reflect the actual logic.

@hvy hvy added the document Documentation related. label Jul 15, 2020
@hvy hvy mentioned this pull request Jul 16, 2020
Closed
@hvy hvy added this to the v2.0.0 milestone Jul 16, 2020
toshihikoyanase
toshihikoyanase approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your swift action.

HideakiImamura
HideakiImamura approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HideakiImamura HideakiImamura merged commit cf40430 into optuna:master Jul 16, 2020
@HideakiImamura HideakiImamura self-assigned this Jul 16, 2020
@hvy hvy deleted the doc-importance-default-eval branch July 16, 2020 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toshihikoyanase toshihikoyanase toshihikoyanase approved these changes

@HideakiImamura HideakiImamura HideakiImamura approved these changes

Assignees

@HideakiImamura HideakiImamura

Labels
document Documentation related.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

default importance evaluator
3 participants
@hvy @toshihikoyanase @HideakiImamura