Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Sphinx up to 3.4.0 #2127

Merged
merged 1 commit into from Dec 21, 2020
Merged

Bump Sphinx up to 3.4.0 #2127

merged 1 commit into from Dec 21, 2020

Conversation

crcrpar
Copy link
Contributor

@crcrpar crcrpar commented Dec 20, 2020

related #1614

Also, bump up sphinx rtd theme.
@crcrpar crcrpar added the document Documentation related. label Dec 20, 2020
@codecov-io
Copy link

Codecov Report

Merging #2127 (0f746ee) into master (f65e66b) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2127      +/-   ##
==========================================
- Coverage   92.29%   92.27%   -0.03%     
==========================================
  Files         123      123              
  Lines        9972     9972              
==========================================
- Hits         9204     9202       -2     
- Misses        768      770       +2     
Impacted Files Coverage Δ
optuna/integration/botorch.py 96.88% <0.00%> (-0.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f65e66b...0f746ee. Read the comment docs.

Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I confirmed that CI downloaded the sphinx 3.4.0 and succeeded. LGTM.

Collecting sphinx
  Downloading Sphinx-3.4.0-py3-none-any.whl (2.9 MB)

@HideakiImamura
Copy link
Member

@hvy Could you review this PR?

Copy link
Member

@hvy hvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch, LGTM!

Worked well on RTD as well (https://hvy-optuna.readthedocs.io/en/bump-sphinx-340-hvy/).

@hvy hvy merged commit dd81baf into optuna:master Dec 21, 2020
@hvy hvy added this to the v2.4.0 milestone Dec 21, 2020
@hvy hvy mentioned this pull request Dec 21, 2020
@crcrpar crcrpar deleted the bump-sphinx-340 branch December 21, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants