Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy local fails in tests/test_deprecated.py and tests/test_experimental.py #2191

Merged

Conversation

HideakiImamura
Copy link
Member

Motivation

This PR aims to fix the mypy . command failure in the local environment.

  • Before

スクリーンショット 2021-01-13 7 18 34

  • After

スクリーンショット 2021-01-13 7 20 26

Description of the changes

  • Add several assertions to ensure the message is Warning.

@HideakiImamura HideakiImamura added the other Issue/PR that does not fit into any other label. label Jan 12, 2021
@HideakiImamura
Copy link
Member Author

@keisuke-umezawa @hvy Could you review this PR if you have time?

@codecov-io
Copy link

Codecov Report

Merging #2191 (5e555ff) into master (b4595a6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2191   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files         124      124           
  Lines       10312    10312           
=======================================
  Hits         9497     9497           
  Misses        815      815           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4595a6...5e555ff. Read the comment docs.

Copy link
Member

@hvy hvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

So, this happens with the later versions of pytest (not with e.g. v5), and it doesn't manifest in the CI since pytest isn't installed for the type checking job. Is this understanding correct?

Copy link
Member

@keisuke-umezawa keisuke-umezawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keisuke-umezawa keisuke-umezawa merged commit aa3f55e into optuna:master Jan 13, 2021
@HideakiImamura HideakiImamura added this to the v2.5.0 milestone Jan 13, 2021
@HideakiImamura HideakiImamura deleted the other/fix-mypy-local-fails branch June 9, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other Issue/PR that does not fit into any other label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants